Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --decorate from katas #178

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Remove --decorate from katas #178

merged 1 commit into from
Mar 25, 2019

Conversation

JKrag
Copy link
Contributor

@JKrag JKrag commented Mar 23, 2019

The --decorate option is default in git log, and provides no value in
the form where it is currently used in the examples.

The --decorate option is default in git log, and provides no value in
the form where it is currently used in the examples.
@sofusalbertsen
Copy link
Contributor

Can't seem to find the documentation that says that decorate is default. Otherwise 👍

@RandomSort
Copy link
Contributor

git/git@940a911
:D

@RandomSort RandomSort merged commit fc4849b into master Mar 25, 2019
@JKrag
Copy link
Contributor Author

JKrag commented Mar 25, 2019

@RandomSort That was the hardcore answer to @sofusalbertsen's question :-)

I would probably have posted:

$ git help log
....
       --no-decorate, --decorate[=short|full|auto|no]
           Print out the ref names of any commits that are shown. If short is
           specified, the ref name prefixes refs/heads/, refs/tags/ and
           refs/remotes/ will not be printed. If full is specified, the full
           ref name (including prefix) will be printed. If auto is specified,
           then if the output is going to a terminal, the ref names are shown
           as if short were given, otherwise no ref names are shown. *The
           default option is short.*

Doing that, however, it is worth noticing that the default is actually now short, even though the commit you linked to suggest auto in the headline (although the code/tests seems to collaborate short)

@JKrag JKrag deleted the remove-decorate branch March 25, 2019 09:47
@sofusalbertsen
Copy link
Contributor

<3 you two!

CristianStanciu pushed a commit to CristianStanciu/git-katas that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants