Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed how shell script could be sourced in katas #235

Merged
merged 1 commit into from
Apr 15, 2020
Merged

changed how shell script could be sourced in katas #235

merged 1 commit into from
Apr 15, 2020

Conversation

schiluveri
Copy link
Collaborator

All README.md files from the suggested list* have been updated to use source command instead of ..

@schiluveri schiluveri linked an issue Apr 9, 2020 that may be closed by this pull request
Consider if we should use . setup.sh instead of ./setup.sh #59
Closed
JKrag
JKrag reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@JKrag JKrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there a specific reason why you only changed the ones in the overview, not the remaining handful?

@schiluveri
Copy link
Collaborator Author

Looks good to me. Is there a specific reason why you only changed the ones in the overview, not the remaining handful?

Apparently, all setup instructions that stated to use . were replaced with source. If you find any other instance, let me know ;)

@schiluveri schiluveri closed this Apr 9, 2020
@schiluveri
Copy link
Collaborator Author

Re-opening (closed this PR unintentionally.)

@schiluveri schiluveri reopened this Apr 9, 2020
@JKrag JKrag merged commit bba8d07 into master Apr 15, 2020
@JKrag JKrag deleted the git-katas-issue-59 branch April 15, 2020 10:29
CristianStanciu pushed a commit to CristianStanciu/git-katas that referenced this pull request Jun 2, 2022
@JKrag
Merge pull request eficode-academy#235 from praqma-training/git-katas…
f5d7e8d 
…-issue-59

changed how shell script could be sourced in katas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKrag JKrag JKrag left review comments

@RandomSort RandomSort RandomSort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider if we should use . setup.sh instead of ./setup.sh
3 participants
@schiluveri @RandomSort @JKrag