Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manual testing check #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TurekBot
Copy link

We discussed improving the check a bit in #28.

Previously, myself and other users found that it was difficult to know what we had done wrong.

Intent

I hope that these changes

  • make it easier for people to know what they're missing
  • make the check specific to general actions and less specific to
    • ordering of words
    • specific words
    • combination or separation of steps

Test Cases

I've checked it against the following sets of manual steps:

Open the app by going to localhost:7272
Fill in the username
Fill in the password
Click the login button
Check you're on the Welcome page
Open the browser to http://localhost:7272
Put in the username and password
Log in and check that you're on the Welcome page
Open browser to localhost:7272
Enter "demo" in username field
Enter "mode" in password field
Click the login button
Check that you're taken to the welcome page
Check that you can log out
Try entering bad credentials
Ensure that when you do, you see an error page
Open browser
Navigate to localhost:7272
Enter username
Enter password
Submit login form
Check that welcome page text is visible

Any feedback is welcome!

Yet we're not "giving the answers to the test" by telling them exactly what they're missing.
Previously, if you reasonably had two steps in one line—like if you said "Open browser to localhost:7272"—the check would never pass.

Now, instead, we check every line for the criteria.
Before, "Open the browser..." would not have passed this check; now it will.
Previously, if you hadn't checked for the welcome page in your steps, you'd have no hint as to what you were missing.

Now, we give you a hint
This allows people to say to "Log in" or to use the "login button"
I found that if you run the script from another folder, things react unexpectedly. So it seems like a good idea to double-check.
@TurekBot TurekBot force-pushed the improve-manual-testing-check branch from d4420ac to 167deb1 Compare March 27, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant