-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental java agent support #42
Conversation
I can revert formatter changes if you want to. Forgot that our company formatter does all kinds of things. |
JavaFXLibrary can now be attached to process as java agent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Looks good!
Was thinking if we should add a separate keyword for this, like We should also update the docs (both readme and keyword documentation) about how to get started with the library, I think currently there is no mention about the required usage of Launch JavaFX Application elsewhere at all. But this can be done outside of this PR. |
We should have the same as with README.md about the java agent -mode in JavaFXLibrary\src\main\java\libdoc-documentation.txt, it goes in the general section of documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
I agree with new keyword for attaching. Maybe keyword should be I would also add support for attaching to process via Java Attach API. I investigated that it could be done pretty easily but build tools need to have |
Automatic init would make sense since the user is already telling that I want to attach to this process by setting the library as an agent. Then again a separate keyword would give the user more control.
This could be the best option since the user would still have control over when the initialization happens, but it would just work automatically. I'll create an issue for this. |
JavaFXLibrary can now be attached to process as java agent.