Make it compatible with Electron #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please approve this!! |
|
Can working directory be a parameter to the functions so it's not a breaking change? If the value isn't passed it can default to __dirname. |
|
@jakesjews I do not think that is the best solution because, by default, it will fail in Electron, but if you prefer, I can do it. |
|
I would prefer that so we don't need to make a breaking change |
|
looks good thanks! |
|
Released in 3.1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
__dirnamewhen running in electron is/home/koraniar/GitHub/leopardcreek-app/dist_electron/linux-unpacked/resources/app.asarandapp.asaris a file not a directory.So the actions
dirandmkdirfails with the error Error: spawn ENOTDIR.Closes #19