Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9.2] Problem with .bans #1297

Closed
wilkowy opened this issue Jun 16, 2022 · 4 comments · Fixed by #1525
Closed

[1.9.2] Problem with .bans #1297

wilkowy opened this issue Jun 16, 2022 · 4 comments · Fixed by #1525
Milestone

Comments

@wilkowy
Copy link
Contributor

wilkowy commented Jun 16, 2022

Eggdrop 1.9.2

There is problem with command .bans and probably .exempts and .invites as well.

The test were carried out on a busy bot with many users, bans and a few channels. Let's assume we have such environment: we have some global bans; #first_chan is a channel on top op eggdrop.chan so this is the first channel in .status; #chan_with_some_bans which has a test timed-ban for the test purposes; and #chan_with_no_ban is the channel with no local bans.

Now the test (mind using the global console channel):

  • .console #chan_with_some_bans
Set your console to #chan_with_some_bans: mjkcoblxsw (msgs, joins, kicks/modes, cmds, misc, bots, linked bot msgs, files, server input, wallops).

.bans

Global bans:
Channel bans for #chan_with_some_bans:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans all

Global bans:   (! = not active on #chan_with_some_bans)
[...]
Channel bans for #chan_with_some_bans:   (! = not active, * = not placed by bot)
[...]

.bans #chan_with_some_bans

Global bans:
Channel bans for #chan_with_some_bans:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans #first_chan

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.
  • .console #chan_with_no_ban
Set your console to #chan_with_no_ban: mjkcoblxsw (msgs, joins, kicks/modes, cmds, misc, bots, linked bot msgs, files, server input, wallops).

.bans

Global bans:
Channel bans for #chan_with_no_ban:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans all

Global bans:   (! = not active on #chan_with_no_ban)
[...]
Channel bans for #chan_with_no_ban:   (! = not active, * = not placed by bot)

.bans #chan_with_some_bans

Global bans:
Channel bans for #chan_with_some_bans:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans #first_chan

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.
  • .console #first_chan
Set your console to #first_chan: mjkcoblxsw (msgs, joins, kicks/modes, cmds, misc, bots, linked bot msgs, files, server input, wallops).

.bans

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.

.bans all

Global bans:   (! = not active on #first_chan)
[...]
Channel bans for #first_chan:   (! = not active, * = not placed by bot)
[...]

.bans #chan_with_some_bans

Global bans:
Channel bans for #chan_with_some_bans:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans #first_chan

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.
  • .console *
Your console is *: mjkcoblxsw (msgs, joins, kicks/modes, cmds, misc, bots, linked bot msgs, files, server input, wallops).

.bans

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.

.bans all

Global bans:   (! = not active on #first_chan)
[...]
Channel bans for #first_chan:   (! = not active, * = not placed by bot)
[...]

.bans #chan_with_some_bans

Global bans:
Channel bans for #chan_with_some_bans:  (* = not placed by bot)
Use '.bans all' to see the total list.

.bans #first_chan

Global bans:
Channel bans for #first_chan:  (* = not placed by bot)
[...]
Use '.bans all' to see the total list.

As you can see this code does not work..

@vanosg
Copy link
Member

vanosg commented Jun 16, 2022

Hi @wilkowy ... sorry, its still early here- could you briefly summarize what you expect to happen and what is not happening? Thanks a ton

@vanosg
Copy link
Member

vanosg commented Oct 5, 2022

Hi @wilkowy - we want to look into this, but still not sure what the specific problem you're identifying is. Can you rephrase it, so we know where to focus our attention? Otherwise we'll have to close this out. Thanks for the help!

@wilkowy
Copy link
Contributor Author

wilkowy commented Oct 8, 2022

The issue is that when .console * is used then .bans/exempts/invites commands take the first channel from the userlist. The expected behavior would be to iterate through all channels and list their active bans or ignore the command.

Also when using .bans #channel (on different console channel) it is not possible to show all bans despite "Use '.bans all' to see the total list." line.

@vanosg
Copy link
Member

vanosg commented Oct 9, 2022

thanks for the additional clarification!

@vanosg vanosg added this to the v1.10 milestone Dec 17, 2022
vanosg added a commit that referenced this issue Jan 20, 2024
Found by: @wilkowy
Patch by: Geo
Fixes: #1297

Prior to this patch, .bans was inconsistent. With a console of '*', Eggdrop only reported channels bans of the first channel in the channel record, and .bans #channel didn't report the bans on the requested channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants