Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip register tsconfig-paths if tsconfig.json not exists #261

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 6, 2023

Avoid warning message: Couldn't find tsconfig.json. tsconfig-paths will be skipped

closes #254 (comment)

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Avoid warning message: Couldn't find tsconfig.json. tsconfig-paths will be skipped

closes #254 (comment)
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b7af12) 99.76% compared to head (f3904a3) 99.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2963     2969    +6     
  Branches      554      556    +2     
=======================================
+ Hits         2956     2962    +6     
  Misses          7        7           
Impacted Files Coverage Δ
lib/loader/egg_loader.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit 24a0d64 into master Apr 6, 2023
@fengmk2 fengmk2 deleted the fix-tsconfig-paths branch April 6, 2023 10:23
fengmk2 pushed a commit that referenced this pull request Apr 6, 2023
[skip ci]

## [5.3.1](v5.3.0...v5.3.1) (2023-04-06)

### Bug Fixes

* skip register tsconfig-paths if tsconfig.json not exists ([#261](#261)) ([24a0d64](24a0d64)), closes [/github.com//pull/254#issuecomment-1493713971](https://github.com/eggjs//github.com/eggjs/egg-core/pull/254/issues/issuecomment-1493713971)
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fengmk2 added a commit that referenced this pull request Apr 6, 2023
Avoid warning message: Couldn't find tsconfig.json. tsconfig-paths will be skipped

closes #254 (comment)

pick from #261
fengmk2 added a commit that referenced this pull request Apr 7, 2023
Avoid warning message: Couldn't find tsconfig.json. tsconfig-paths will be skipped

closes #254 (comment)

pick from #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant