feat: add test support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
fengmk2
reviewed
Nov 14, 2016
| @@ -2,29 +2,59 @@ | |||
|
|
|||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const coffee = require('coffee'); | |||
| // const coffee = require('coffee'); | |||
There was a problem hiding this comment.
测试构建这块, 是直接 require 还是通过 coffee 启动来验证好呢? 前者的话, 会遇到上次那个问题, 验证不了 bin 文件.
如果这样, 那个 helper 就要看看怎么做到, 要看 coffee 如何 hack stdin
There was a problem hiding this comment.
这次先不管 coffee 这个, 下个 PR 我再看看怎么搞
|
测试一直卡住的？ |
|
之前没有 egg-ci, 现在重新跑, 晚上再修下 |
|
挂了？ |
|
修复了, 白天是因为 npm 的环境变量, registryUrl 带有 最近感觉 travis-ci 执行好慢, 拉不到 github 的源码. |
|
我们晚上西方是白天，所以量就大了 |
|
想吐血... 测试一直不过是因为 fixtures 被 ignore 了... 测试一直不跑是因为这个勾... |
Current coverage is 81.92% (diff: 77.27%)
|
|
cc @popomore 过了... |
|
+1 |
fengmk2
reviewed
Nov 20, 2016
| @@ -0,0 +1,5 @@ | |||
| -r intelli-espower-loader | |||
| -r ./node_modules/egg-bin/node_modules/thunk-mocha | |||
There was a problem hiding this comment.
好吧, 这个 opts 我全局干掉好了. 之前是为了方便 webstorm.
There was a problem hiding this comment.
done, 其他几个 boilerplate 的都提 PR 干掉了
|
1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
初步实现单元测试功能, 增加一个 helper, 这样 boilerplate 那边也可以用 egg-init 来测试自己
先 review 下看看有没有问题