[WIP]feat:support inject context to do isomorphic #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtyjty99999, thanks for your PR! By analyzing the history of the files in this pull request, we identified @atian25 to be a potential reviewer. |
jtyjty99999
force-pushed
the
contextInject
branch
from
0f2894a to
b7d1e2a
Compare
atian25
reviewed
Mar 12, 2017
| @@ -5,9 +5,12 @@ const path = require('path'); | |||
| module.exports = appInfo => { | |||
| const config = {}; | |||
|
|
|||
| config.view = { | |||
| config.react = { | |||
| extname: 'js', | |||
| dir: path.join(appInfo.baseDir, 'app/view'), | |||
|
强烈支持一个，加速进度😊😊 |
jtyjty99999
force-pushed
the
contextInject
branch
3 times, most recently
from
e369bb8 to
54376e3
Compare
|
@jtyjty99999 同构这个先不管，先发一个 SSR 的 1.0 版本？ |
jtyjty99999
force-pushed
the
contextInject
branch
from
54376e3 to
66aa25e
Compare
popomore
reviewed
Jun 26, 2017
| exports.view = { | ||
| defaultViewEngine: 'react', | ||
| mapping :{ | ||
| '.js':'react' |
popomore
reviewed
Jun 26, 2017
| "react": "^15.4.2", | ||
| "react-dom": "^15.4.2" | ||
| "escape-html": "^1.0.3", | ||
| "react": "^15.5.4", |
There was a problem hiding this comment.
@popomore 正在升级插件(支持单页面同构，去掉内置 react 依赖），react 和 react-dom 不想再内置插件，大家意见？
There was a problem hiding this comment.
写个 peerdep 吧，不然前后端会有多个 react 版本
|
这个怎么用啊，我都报了好多错啊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change