feat: add getLogger to app and ctx #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers. |
|
看来 eslint break 了 eslint/eslint#7403 |
popomore
force-pushed
the
get-logger
branch
2 times, most recently
from
c2ec69a to
8d2ceb2
Compare
Current coverage is 95.69% (diff: 100%)@@ master #136 diff @@
==========================================
Files 33 33
Lines 832 836 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 796 800 +4
Misses 36 36
Partials 0 0
|
popomore
force-pushed
the
get-logger
branch
2 times, most recently
from
bb0743e to
8a36b84
Compare
|
+1 |
|
rebase 一下 |
|
把 circle ci 关了？ |
|
circle 关了 |
fengmk2
reviewed
Nov 2, 2016
| @@ -45,6 +45,7 @@ exports.startLocalServer = () => { | |||
| }); | |||
| }); | |||
| }; | |||
| process.once('exit', () => localServer.close()); | |||
There was a problem hiding this comment.
好吧，mocha 好像不管是否还有 server，都是自己退出的。
fengmk2
reviewed
Nov 2, 2016
| @@ -5,7 +5,7 @@ const urllib = require('../../../lib/core/urllib'); | |||
|
|
|||
| describe('test/lib/core/urllib.test.js', () => { | |||
| let client; | |||
| const url = 'https://a.alipayobjects.com/aliBridge/1.0.0/aliBridge.min.js'; | |||
| const url = 'http://www.google.com/generate_204'; | |||
There was a problem hiding this comment.
改成 localServer 的吧，要不然本地运行这个 ci google 别墙，跑不过。
it can be override with custom function Closes #36
|
改了 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
app and ctx
Description of change
it can be override with custom function
Closes #36