Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deployment): adjust with new version egg-scripts #1757

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Nov 29, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

eggjs/scripts#16

@codecov-io
Copy link

Codecov Report

Merging #1757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1757   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          29       29           
  Lines         717      717           
=======================================
  Hits          714      714           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9c9a4...fea0465. Read the comment docs.

```

该命令将杀死 master 进程,并通知 worker 和 agent 优雅退出。

支持以下参数:
- `--title=egg-server` 用于杀死指定的 egg 应用,未传递则会 killapp。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未传递则会 killapp

这句有点看不懂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前最新的 egg-scripts stop 会杀死机器上的所有 egg 应用

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

killall 我写错了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没 push?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

额,好像在 GitHub 这边 update 后,push 就要 -f 才行。
推了

@dead-horse dead-horse merged commit d752b3b into master Nov 29, 2017
@dead-horse dead-horse deleted the docs-stop branch November 29, 2017 08:42
popomore pushed a commit that referenced this pull request Nov 29, 2017
docs(deployment): adjust with new version egg-scripts (#1757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants