Chore: Fix some typo translations #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) For 'app-start.md': We don't need 'too time-consuimg' but just 'long-time' enough. 2) For 'en.yml' and 'zh-cn.yml': 2.1) Uncomment the 'Loader' because we've finished the related article. 2.2) Make sure that 'translations' are the same language in both Chinese and English. 2.3) Translation 'Loader', 'Controller','Router' and 'Service' in Chinese.
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #3361 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 29 29
Lines 844 844
=======================================
Hits 842 842
Misses 2 2Continue to review full report at Codecov.
|
atian25
approved these changes
Jan 4, 2019
popomore
pushed a commit
that referenced
this pull request
Jan 4, 2019
Chore: Fix some typo translations (#3361) 1) For 'app-start.md': We don't need 'too time-consuimg' but just 'long-time' enough. 2) For 'en.yml' and 'zh-cn.yml': 2.1) Uncomment the 'Loader' because we've finished the related article. 2.2) Make sure that 'translations' are the same language in both Chinese and English. 2.3) Translate 'Loader', 'Controller','Router' and 'Service' in Chinese. Self Link：#3361
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1) For 'app-start.md':
We don't need 'too time-consuimg' but just 'long-time' enough.
2) For 'en.yml' and 'zh-cn.yml':
2.1) Uncomment the 'Loader' because we've finished the related article.
2.2) Make sure that 'translations' are the same language in both Chinese and English.
2.3) Translate 'Loader', 'Controller','Router' and 'Service' in Chinese.
npm testpasses