Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issue template #3369

Merged
merged 3 commits into from
Jan 11, 2019
Merged

chore: fix issue template #3369

merged 3 commits into from
Jan 11, 2019

Conversation

thonatos
Copy link
Member

@thonatos thonatos commented Jan 8, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • fix issue template

@whxaxes
Copy link
Member

whxaxes commented Jan 8, 2019

顺便改改这个?#3366 (comment)

@atian25 atian25 changed the title Chore: fix issue template chore: fix issue template Jan 8, 2019
@atian25
Copy link
Member

atian25 commented Jan 8, 2019

为啥你们 2 个的 PR,title 都喜欢首字母大写呢。

@whxaxes 那个我在 #3370 改了

@thonatos
Copy link
Member Author

thonatos commented Jan 8, 2019

@atian25

标题习惯首字母大写了

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #3369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3369   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef73396...d4723f9. Read the comment docs.

@eggjs eggjs deleted a comment Jan 11, 2019
@atian25 atian25 merged commit 9a4b720 into master Jan 11, 2019
@atian25 atian25 deleted the chore/fix-issue-template branch January 11, 2019 05:38
popomore pushed a commit that referenced this pull request Jan 11, 2019
chore: fix issue template (#3369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants