feat: support single process mode #3430
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3430 +/- ##
==========================================
+ Coverage 99.76% 99.78% +0.01%
==========================================
Files 29 32 +3
Lines 844 911 +67
==========================================
+ Hits 842 909 +67
Misses 2 2
Continue to review full report at Codecov.
|
lib/core/messenger/local.js
Outdated
| const EventEmitter = require('events'); | ||
|
|
||
| /** | ||
| * Communication between app worker and agent worker by IPC channel |
lib/core/messenger/local.js
Outdated
| opposite = application; | ||
| } | ||
|
|
||
| // use nextTick to keep it asyn as IPC messenger |
| const Agent = require('./agent'); | ||
|
|
||
| module.exports = async (options = {}) => { | ||
| options.baseDir = options.baseDir || process.cwd(); |
There was a problem hiding this comment.
这里考虑加入 timeout 参数， timeout 之后需要 close agent 和 application。
|
绝大部分和 cluster 模式兼容，但是仍然有无法兼容的地方，需要文档中列出来：
开发环境（egg-development）需要适配，由于没有 egg-cluster，需要看看怎么实现热重启（或者不做热重启，和 koa 一样交给用户处理） |
这个不好吧，都提供 listen 接口了，为何不能拿到 server 事件。 |
和 koa 一样，用户可以 |
lib/start.js
Outdated
|
|
||
| module.exports = async (options = {}) => { | ||
| options.baseDir = options.baseDir || process.cwd(); | ||
| options.singleProcess = true; |
There was a problem hiding this comment.
options.mode=cluster/single 怎么样？
There was a problem hiding this comment.
对外可以考虑统一一个 start(options) 的入口，然后里面可以转调 startCluster，这样的话 egg-bin 和 egg-scripts 那边不用判断 options
|
messenger 这还有个场景，之前的用法里面，进程是可以直接 |
文档有写这个用法么？ |
Guide 文档没有写，在 egg-cluster 的 messenger 源码有，然后很多地方的单元测试好像都这么用 |
|
恩，这个问题不大，文档说明一下好了 |
|
这个完成后，本地开发可以直接用单进程模式了吧，egg-bin debug 那块就能简单多了。 |
| const Agent = require('./agent'); | ||
|
|
||
| module.exports = async (options = {}) => { | ||
| console.warn('single process mode is still in experiment, please don\'t use it in production environment'); |
There was a problem hiding this comment.
先加一个 warn 信息，发个版本，用来调试
dead-horse
changed the title
feat: support single process mode (#3430)
| const Application = require('./application'); | ||
| const Agent = require('./agent'); | ||
|
|
||
| module.exports = async (options = {}) => { |
There was a problem hiding this comment.
我最终想是在 egg-cluster 实现的，这样 API 也比较统一
There was a problem hiding this comment.
为啥要在 egg-cluster 实现？ egg 就应该是一个可以自运行的服务，和 koa 一样
There was a problem hiding this comment.
egg-cluster 像 pm2，是 egg 的进程管理工具。
There was a problem hiding this comment.
主要是现在 chair-script, egg-script 里都写死调用的是 startCluster。
现在 faas 那边，我是自己覆盖了 startCluster 来搞的
There was a problem hiding this comment.
egg-cluster 也可以增加一个参数直接调用 egg 的 start 方法。
There was a problem hiding this comment.
我记得当时那个 PR 里面我提过，startCluster 里面判断下调用的
There was a problem hiding this comment.
同意死马，egg 应该不依赖 cluster 就能够启动。单进程模式，应该推荐直接初始化 egg 的实例就来启动服务的。在容器里面运行，甚至都不要 cfork，egg 进程死掉的话，交给 k8s 来重启。
不过直接干掉 agent 可能会引起一些插件不兼容。
There was a problem hiding this comment.
同意死马，egg 应该不依赖 cluster 就能够启动。单进程模式，应该推荐直接初始化 egg 的实例就来启动服务的。在容器里面运行，甚至都不要 cfork，egg 进程死掉的话，交给 k8s 来重启。
不过直接干掉 agent 可能会引起一些插件不兼容。
赞同
|
可以问下这里单进程是啥进度了吗？调用方式是？有文档吗？ |
|
我们内部才开始实践中，要下半年吧 |
|
已经用起来了！ |
warning 我们干掉了么？ |
感觉可以。 |
Since we're now successfully using this feature for a long time without obvious bugs/errors, there's no need for us to make it as an "experinment" feature and now it's come to ture. Ref: eggjs#3430
Since we're now successfully using this feature for a long time without obvious bugs/errors, there's no need for us to make it as an "experinment" feature and now it's come to ture. Ref: #3430
No description provided.