Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update egg-multipart 2.x -> 3.x #5023

Merged
merged 4 commits into from
Sep 21, 2022
Merged

feat: update egg-multipart 2.x -> 3.x #5023

merged 4 commits into from
Sep 21, 2022

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Sep 21, 2022 •
edited
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@vercel
Copy link

vercel bot commented Sep 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
egg ❌ Failed (Inspect) Sep 21, 2022 at 7:55AM (UTC)

@atian25 atian25 mentioned this pull request Sep 21, 2022
Closed
@fengmk2
Copy link
Member

fengmk2 commented Sep 21, 2022

看起来 ts 版本需要升级一下
Error: node_modules/_@types_express-serve-static-core@4.17.31@@types/express-serve-static-core/index.d.ts(1152,18): error TS1005: ';' expected.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 99.74% // Head: 99.68% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (e418ec7) compared to base (64dd9fe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5023      +/-   ##
==========================================
- Coverage   99.74%   99.68%   -0.06%     
==========================================
  Files          35       35              
  Lines        1159     3529    +2370     
  Branches      194      522     +328     
==========================================
+ Hits         1156     3518    +2362     
- Misses          3       11       +8
Impacted Files Coverage Δ
lib/agent.js 100.00% <100.00%> (ø)
lib/application.js 100.00% <100.00%> (ø)
lib/core/messenger/ipc.js 100.00% <100.00%> (ø)
lib/core/messenger/local.js 100.00% <100.00%> (ø)
lib/egg.js 100.00% <100.00%> (ø)
lib/core/utils.js 95.83% <0.00%> (-4.17%) ⬇️
app/middleware/meta.js 83.33% <0.00%> (-3.34%) ⬇️
lib/core/httpclient_next.js 94.87% <0.00%> (-0.13%) ⬇️
agent.js 100.00% <0.00%> (ø)
index.js 100.00% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

atian25
atian25 commented Sep 21, 2022
View reviewed changes
package.json
"egg-session": "^3.1.0",
"egg-logger": "^2.9.0",
"egg-logrotator": "^3.1.0",
"egg-multipart": "^3.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x

@fengmk2 fengmk2 merged commit 733d669 into master Sep 21, 2022
@fengmk2 fengmk2 deleted the multipart branch September 21, 2022 08:05
@fengmk2
Copy link
Member

fengmk2 commented Sep 21, 2022

3.2.0

@atian25
Copy link
Member Author

atian25 commented Sep 21, 2022

@thonatos docs deploy 挂了，有空看看

@thonatos
Copy link
Member

@thonatos docs deploy 挂了，有空看看

CI 也挂了，我一起看看

iblogc pushed a commit to iblogc/egg that referenced this pull request Jan 9, 2023
@atian25 @iblogc
feat: update egg-multipart 2.x -> 3.x (eggjs#5023)
87d77e3 
closes eggjs#5018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
plugin: egg-multipart type: feature
Projects
None yet
Milestone
No milestone
3 participants
@atian25 @fengmk2 @thonatos