Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: egg-view-nunjucks change views -> view #72

Merged
merged 1 commit into from
Sep 1, 2016
Merged

test: egg-view-nunjucks change views -> view #72

merged 1 commit into from
Sep 1, 2016

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Aug 31, 2016 •
edited
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • 升级 egg-view-nunjucks
  • views 目录改为 view

@atian25 atian25 mentioned this pull request Aug 31, 2016
Merged
4 tasks
@fengmk2
Copy link
Member

fengmk2 commented Aug 31, 2016

ci 挂了？

@atian25
Copy link
Member Author

atian25 commented Aug 31, 2016

刚才漏了 example 目录下的测试. (现在本地单测好慢

@fengmk2
Copy link
Member

fengmk2 commented Aug 31, 2016

还是挂了，而且还有 only

@atian25
Copy link
Member Author

atian25 commented Sep 1, 2016 •
edited
Loading

only 干掉了, 单测挂的是 cookie 和 security

都是 eggjs/security#4 导致的

@fengmk2
Copy link
Member

fengmk2 commented Sep 1, 2016

好，那我修

@fengmk2 fengmk2 merged commit c888d79 into master Sep 1, 2016
@fengmk2 fengmk2 deleted the views-view branch September 1, 2016 01:20
@XadillaX XadillaX mentioned this pull request Jan 9, 2023
Open
elrrrrrrr pushed a commit to elrrrrrrr/egg that referenced this pull request Feb 21, 2023
@brucx @popomore
fix: fix typo (eggjs#72)
f109df1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atian25 @fengmk2