refactor: use FileLoader to load schedule files #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
egg-core 需要改下，用 realpath 解析 plugin 目录 |
| @@ -1,3 +1,3 @@ | |||
| 'use strict'; | |||
|
|
|||
| exports.logrotater = true; | |||
| exports.logrotator = true; | |||
There was a problem hiding this comment.
这个插件是不是不用开了？下面那个用例自己造一个node_modules目录写个假任务。
不然耦合另一个插件来测试在这里不是很必要吧。
|
+1 |
|
等 egg-core 合并重跑下 |
popomore
force-pushed
the
fileloader
branch
2 times, most recently
from
e217c3f to
0dc6f1a
Compare
Current coverage is 80.70% (diff: 100%)@@ master #7 diff @@
==========================================
Files 3 3
Lines 119 114 -5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 98 92 -6
- Misses 21 22 +1
Partials 0 0
|
|
这个可以重新跑下了 |
|
已经重新跑了 |
|
2.1.0 |
|
+1 |
|
太棒！有了通用loader复用不再是问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Loader
Description of change
重写 Loader，简化代码
eggjs/egg#48