Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: always add trailing comma when multiline #4

Merged
merged 3 commits into from
Oct 9, 2018
Merged

refactor: always add trailing comma when multiline #4

merged 3 commits into from
Oct 9, 2018

Conversation

popomore
Copy link
Member

@popomore popomore commented Oct 9, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from whxaxes October 9, 2018 13:26
@popomore
Copy link
Member Author

popomore commented Oct 9, 2018

Node8 已经支持 function 的 trailing comma 了

@whxaxes
Copy link
Member

whxaxes commented Oct 9, 2018

本来是 always 的，不过考虑到跟 eslint-config-egg 保持一致，所以改成 function 就不用了

@popomore
Copy link
Member Author

popomore commented Oct 9, 2018

eslint 现在也可以改成 always 了，原来是 Node 不支持

@whxaxes
Copy link
Member

whxaxes commented Oct 9, 2018

OK，那就都改一下吧，保持一致好些

@popomore
Copy link
Member Author

popomore commented Oct 9, 2018

eslint 改的话要 drop node6

@popomore popomore merged commit 3835423 into master Oct 9, 2018
@popomore popomore deleted the trailing-comma branch October 9, 2018 13:59
@popomore
Copy link
Member Author

popomore commented Oct 9, 2018

  • tslint-config-egg@1.0.0-alpha.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whxaxes whxaxes whxaxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popomore @whxaxes