Add dns-account-01 support from draft-ietf-acme-scoped-dns-challenges #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I will pull this in later today. |
sheurich
commented
Feb 21, 2024
| @@ -169,7 +171,7 @@ func makeOrderFinalised(t *testing.T, supportedChalTypes []string, identifiers . | |||
| chalType := supportedChalTypes[mrand.Intn(len(supportedChalTypes))] | |||
| chal, ok := auth.ChallengeMap[chalType] | |||
| if !ok { | |||
| t.Fatalf("No supported challenge %q (%v) in challenges: %v", chalType, supportedChalTypes, auth.ChallengeTypes) | |||
| t.Skipf("skipping, no supported challenge %q (%v) in challenges: %v", chalType, supportedChalTypes, auth.ChallengeTypes) | |||
There was a problem hiding this comment.
This change of a fatal to skip is due to the unconditional execution of TestWildcardDNSAccount when the testing against a Boulder/Pebble instance without dns-account-01 support. There may be a preferable way to accomplish this without making this a skip.
jsha
pushed a commit
to letsencrypt/pebble
that referenced
this pull request
Mar 18, 2024
…es (#435) This change implements the `dns-account-01` ACME challenge as specified in [draft-ietf-acme-scoped-dns-challenges](https://datatracker.ietf.org/doc/draft-ietf-acme-scoped-dns-challenges/). The relevant [validation label computation](https://github.com/aaomidi/draft-ietf-acme-scoped-dns-challenges/blob/0058e0800056698fb37f3b2cb31a727c826675fb/draft-ietf-acme-scoped-dns-challenges.mkd#dns-account-01-challenge) is: ```plain "_" || base32(SHA-256(<ACCOUNT_RESOURCE_URL>)[0:10]) || "._acme-" || <SCOPE> || "-challenge" ``` where SCOPE is one of { `host`, `wildcard` }. A SCOPE of { `domain` } is unimplemented. This implementation is interoperable with the https://github.com/eggsampler/acme changes in eggsampler/acme#21 and passes the `TestWildcardDNSAccount` test. Solves #425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the "dns-account-01" challenge type as specified in:
https://github.com/aaomidi/draft-ietf-acme-scoped-dns-challenges/blob/0058e0800056698fb37f3b2cb31a727c826675fb/draft-ietf-acme-scoped-dns-challenges.mkd#dns-account-01-challenge
The relevant validation label computation is:
Currently SCOPE of
"host"and"wildcard"is implemented, but not SCOPE of"domain".This implementation is interoperable with the Pebble changes in https://github.com/fastly/pebble/tree/add-dns-account-01 and passes the new
TestWildcardDNSAccounttest.Solves #20.