Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: torch.stft will soon require return_complex=True #20

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

eginhard
Copy link
Owner

@eginhard eginhard commented Mar 13, 2024

Refactor that removes the deprecation warning:
torch.view_as_real(torch.stft(*, return_complex=True)) is equal to torch.stft(*, return_complex=False)

https://pytorch.org/docs/stable/generated/torch.stft.html

Fixes coqui-ai#2449, fixes coqui-ai#2639, obsoletes coqui-ai#3319

Refactor that removes the deprecation warning:
torch.view_as_real(torch.stft(*, return_complex=True)) is equal to
torch.stft(*, return_complex=False)

https://pytorch.org/docs/stable/generated/torch.stft.html
@eginhard eginhard merged commit e5c6da1 into dev Mar 13, 2024
35 checks passed
@eginhard eginhard deleted the return-complex branch March 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant