Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest esbuild removes watch flag in build option #35

Open
otakustay opened this issue Jan 25, 2023 · 0 comments
Open

Latest esbuild removes watch flag in build option #35

otakustay opened this issue Jan 25, 2023 · 0 comments

Comments

@otakustay
Copy link
Contributor

According to release notes of v0.17.0, watch option is removed and it cause bundle-require to error:

✘ [ERROR] Invalid option in build() call: "watch"

    /Users/otakustay/Develop/reskript/node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:255:12:
      255 │       throw new Error(`Invalid option ${where}: ${quote(key)}`);
          ╵             ^

    at checkForInvalidFlags (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:255:13)
    at flagsForBuildOptions (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:457:3)
    at buildOrContextContinue (.node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:1009:9)
    at .node_modules/.pnpm/esbuild@0.17.4/node_modules/esbuild/lib/main.js:983:11

To be compatible with multiple version of esbuild, maybe we can make a new option, allow users to pass esbuild.build function directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant