Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix esbuild watch mode #36

Merged
merged 3 commits into from
Feb 7, 2023
Merged

fix: Fix esbuild watch mode #36

merged 3 commits into from
Feb 7, 2023

Conversation

ArcherGu
Copy link
Contributor

@ArcherGu ArcherGu commented Jan 31, 2023

After upgrading esbuild to 0.17.x, the watch option in the BuildOptions did not work. #35

https://github.com/evanw/esbuild/releases/tag/v0.17.0

I fixed this and left a watch option compatible with past versions:

  /**
   * esbuild options
   * 
   * @deprecated `esbuildOptions.watch` is deprecated, use `onRebuild` instead
   */
  esbuildOptions?: BuildOptions & {
    watch?: boolean | {
      onRebuild?: RebuildCallback
    }
  }

We should remove it in some future release.

@egoist egoist changed the title Fix esbuild watch mode fix: Fix esbuild watch mode Feb 7, 2023
@egoist egoist merged commit e82d40c into egoist:main Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants