added update checker for latest release of dum #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the checker uses a get request to github releases to find the latest version from its tag. +Added two libraries "ureq" and "serde" for handling the request.
|
it seems this is blocking until the network request is resolved. ideally, I prefer something like https://github.com/yeoman/update-notifier#how which doesn't block it. |
while ureq is a very minimal http request library, it only implements blocking API. this change requires using tokio for the async function.
|
Actually, I think you misunderstood, this will still wait for a network request before actually parsing the cli args, what I want is to spawn a child process to check for updates and notify if there is an update the next time |
|
My apologies, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28
The checker uses a get request to GitHub releases to find the latest version from its tag. If using GitHub is not ideal, other API's can be used instead such as crates.io .
This change required two additional libraries to make the request and deserialize it. Therefore
ureqandserdewere added to Cargo.toml .If other options are preferred, I would be more than happy to apply them.