Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update dev dependencies #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Gioni06
Copy link

@Gioni06 Gioni06 commented Jan 16, 2019

This PR updates the dependencies so that critical security issues are fixed. (Discovered by npm audit)

Along this change it was necessary to update the gulpfile.js so that it is compatible with the newer Gulp api.

@Gioni06
Copy link
Author

Gioni06 commented Jan 22, 2019

@egoist can i do something to get this PR merged ? 😉

@ghost ghost changed the title Update dependencies Update dev dependencies Jan 24, 2019
@ghost
Copy link

ghost commented Jan 24, 2019

I put a yarn lock file on this repo about a year ago so the dev pipeline wouldn't bust. When I clone fresh today and run yarn audit I see pretty print outs of all the vulnerabilities and a summary:

69 vulnerabilities found - Packages audited: 2922
Severity: 41 Low | 16 Moderate | 11 High | 1 Critical
✨  Done in 2.02s.

When I run npm i --package-lock-only I see a handful of directionless warnings and a summary:

added 707 packages and audited 5506 packages in 7.417s
found 10 vulnerabilities (3 low, 7 high)

Which of these two systems would you place your faith in knowing NPM added lock files in response to Yarn and not because they felt it was important enough to prioritize early?

Given this repo only has any dev deps I don't see a strong need to merge unless active development begins. But we can leave this here for now. Thanks for the pull.

@Gioni06
Copy link
Author

Gioni06 commented Jan 24, 2019

Which of these two systems would you place your faith in knowing NPM added lock files in response > to Yarn and not because they felt it was important enough to prioritize early?

Good point. I haven't used Yarn for quite some time now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant