fix: enable dynamicImport #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried the v2 version and think we're missing a lot of plugins to support a wide range of code, for example, my code requires maybe we need to have a way to exclude only flow/flow-commeents |
|
@KagamiChan there's an option https://github.com/egoist/konan#parse so you can add custom plugins, |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lukeed
reviewed
Jul 15, 2020
| @@ -11,27 +11,18 @@ | |||
| "index.js" | |||
| ], | |||
| "scripts": { | |||
| "test": "jest && npm run lint", | |||
| "lint": "xo index.js __test__/*.test.js" | |||
| "test": "node test/test.js" | |||
There was a problem hiding this comment.
Any particular reason you chose this over uvu test -i fixture ?
Or uvu -r esm test -i fixture for that matter (since esm is already here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we need to detect dynamic imports