-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sourceMaps relative to the CSS output file #274
Conversation
Now shows relative sourceMappingURL, rather than duplicating the full filePath
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 92.68% 92.47% -0.21%
==========================================
Files 10 10
Lines 328 319 -9
Branches 115 112 -3
==========================================
- Hits 304 295 -9
Misses 23 23
Partials 1 1
Continue to review full report at Codecov.
|
Any development on this? I tested this as a fix for visjs/vis-network#968 and visjs/vis-timeline#621, it resulted in the correct path being emitted. |
Tests appear to have failed because of a timeout, rather than any tests failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This seems to work great and makes debugging a little bit easier for custom paths. Thank you for your patience! 🚢
🎉 This PR is included in version 3.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
For the example in:
test/fixtures/dist/extract--custom-path/this/is/extracted.css
the sourceMappingURL was:
/*# sourceMappingURL=this/is/extracted.css.map */
Meaning the browser would try and load the sourcemap from:
this/is/this/is/extracted.css.map
This only happens when someone has set
extract
to something likethis/is/extracted.css
.I've changed this to run the map name through path.basename first, as the map is always dropped in the same folder as the css file.