Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace globby with tinyglobby #1168

Merged
merged 2 commits into from
Aug 24, 2024
Merged

refactor: replace globby with tinyglobby #1168

merged 2 commits into from
Aug 24, 2024

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Jul 22, 2024 •
edited
Loading

supersedes #1167, does basically the same but with globbing logic moved into its own library as suggested by maintainers

this is the followup pr mentioned in #1163. i've opened this mainly to get feedback from the maintainers on the best way to implement this. i can port the globbing code into its own package if needed, even though this isn't that much code

according to globby's readme the only exclusive features it has (that are relevant in this case) are negated patterns and directory expansion, which this pr both covers

the issues reported in 6.2.1 were all related to either me forgetting to handle negated patterns in entry or not knowing directory expansion was meant to be done. if there is any more globby-exclusive functionality missing let me know and i'll add it

i'd be happy to test any possible edge cases in the logic and add new tests

ref: #1163 (comment)

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jul 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 10:06am

@socket-security Socket Security
Copy link

socket-security bot commented Jul 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/globby@11.1.0, npm/typescript@5.5.4

View full report↗︎

@SuperchupuDev SuperchupuDev mentioned this pull request Jul 22, 2024
Closed
@sxzz sxzz force-pushed the no-globby-final-final-please branch from 3cd6aae to 378adf5 Compare July 24, 2024 16:32
sxzz
sxzz reviewed Jul 24, 2024
View reviewed changes
test/utils.ts Outdated Show resolved Hide resolved
@SuperchupuDev SuperchupuDev requested a review from sxzz July 24, 2024 16:39
@sxzz sxzz requested a review from egoist August 6, 2024 20:00
@sxzz sxzz merged commit 3f44303 into egoist:dev Aug 24, 2024
9 checks passed
@SuperchupuDev SuperchupuDev deleted the no-globby-final-final-please branch August 24, 2024 10:53
egoist pushed a commit that referenced this pull request Sep 17, 2024
@SuperchupuDev @egoist
refactor: replace globby with tinyglobby (#1168)
95b1ab7
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@egoist egoist Awaiting requested review from egoist

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperchupuDev @sxzz