Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sourceRoot option #1174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add sourceRoot option #1174

wants to merge 2 commits into from

Conversation

yukukotani
Copy link

@yukukotani yukukotani commented Aug 3, 2024

Add sourceRoot option, which is delegated to esbuild's option.

Copy link

codesandbox bot commented Aug 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:13am

schema.json Outdated Show resolved Hide resolved
src/cli-main.ts Outdated Show resolved Hide resolved
@ocavue ocavue changed the title add sourceRoot option feat: add sourceRoot option Sep 17, 2024
@sxzz sxzz deleted the branch egoist:main September 17, 2024 05:23
@sxzz sxzz closed this Sep 17, 2024
@sxzz sxzz reopened this Sep 17, 2024
@sxzz sxzz changed the base branch from dev to main September 17, 2024 05:37
Copy link
Collaborator

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for ocavue's comments.

Copy link
Author

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocavue Thank you for reviewing. Applied.

@yukukotani yukukotani requested a review from ocavue September 17, 2024 06:12
Co-authored-by: ocavue <ocavue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants