Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add experimentalDts.only #1237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add experimentalDts.only #1237

wants to merge 1 commit into from

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Adds experimentalDts.only which is the equivalent of dts.only for experimentalDts.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Oct 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 5:07am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 19, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/egoist/tsup@1237

commit: a6cda79

@aryaemami59 aryaemami59 marked this pull request as ready for review October 22, 2024 15:28
@ocavue
Copy link
Collaborator

ocavue commented Oct 26, 2024

I kind of don't want to add another experimental CLI option. To be honest, I'm not happy with the current @microsoft/api-extractor-based --experimental-dts implementation either, since it requires an ugly _tsup-dts-rollup.d.ts file. I'd prefer to find a more suitable solution before putting in extra effort on top of it.

@ocavue
Copy link
Collaborator

ocavue commented Oct 26, 2024

I really appreciate your recent work around dts. I just need some more thinking before merging them.

@aryaemami59
Copy link
Contributor Author

aryaemami59 commented Oct 26, 2024 •
edited
Loading

@ocavue It's okay I understand. I'm trying to do whatever I can to help fix experimentalDts, it has a lot of potential, it just needs work, and I thought maybe this could be a start. I'm still going to try and see if I can remove _tsup-dts-rollup files, I think if We can accomplish that it'll solve a lot of issues related to experimentalDts.

@aryaemami59
Copy link
Contributor Author

aryaemami59 commented Nov 7, 2024 •
edited
Loading

@ocavue Do you mind if I work on improving experimentalDts,maybe try to come up with an implementation that does away with _tsup-dts-rollup files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @ocavue