fix: make removeNodeProtocol work with shims

[aryaemami59]

This PR:

• Fixes removeNodeProtocol to work with shims.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tsup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 27, 2024 9:08am

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/egoist/tsup@1242

commit: 92b0d02

[sxzz]

removeNodeProtocol is designed for Node compatibility, but if the version supports ESM, the node protocol is natively supported and doesn't need to be removed.

[sxzz]

According to the documentation, the node: protocol is supported in CJS starting from versions v16.0.0 and v14.18.0, and in ESM from versions v14.13.1 and v12.20.0.

Do you think it's necessary to support v12.0.0 >= node < v12.20.0

[aryaemami59]

@sxzz I see what you're saying, I guess the point of the PR is to make removeNodeProtocol apply to shims as well for consistency. Thoughts?