Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
4.14.0
What kind of change does this PR introduce?
Questions
code splitting in esbuild must be esm. see here 👉 esbuild-splitting
When we encounter problems with
__require.resolve
we can solve them withesbuild --format=cjs
But in tsup we can't do that, we have to
tsup --format cjs --no-splitting
I looked at the source code, and find:
--no-splitting
will beundedined
, So that alwaysoptions.splitting !== false
esm
Related bugs
Steps to reproduce
tsup-mini-repo
This is also the first pr I mentioned to tsup. If can merged I will be very happy. And very much open to feedback on this PR if you have suggestions for improvements.