added boundary data mapper #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajilo-eGov
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
Could you undo this file rename as well please?
There was a problem hiding this comment.
Could you undo this file rename as well please?
| @@ -29,26 +29,23 @@ class BoundaryBloc extends Bloc<BoundaryEvent, BoundaryState> { | |||
| List<BoundaryModel> boundaryList = await boundaryRepository.search( | |||
| BoundarySearchModel(code: event.code), | |||
| ); | |||
| boundaryList.forEach((ele) => print(ele.code)); | |||
There was a problem hiding this comment.
Please remove this print statement.
Suggested change
| boundaryList.forEach((ele) => print(ele.code)); |
| @@ -47,9 +51,14 @@ class AuthenticatedPageWrapperState extends State<AuthenticatedPageWrapper> { | |||
| (boundaryList, boundaryMapperList, selectedBoundary) { | |||
| if (boundaryList.isEmpty) return; | |||
|
|
|||
| if (selectedBoundary == null) { | |||
| if (selectedBoundary.isEmpty) { | |||
| setState(() { | |||
| visiable = true; | |||
| .add(BoundaryEvent | ||
| .select( | ||
| selectedBoundary: | ||
| selectedBoundaryValuehierarchy, |
There was a problem hiding this comment.
Suggested change
| selectedBoundaryValuehierarchy, | |
| selectedBoundaryValueHierarchy, |
Typo
| selectedBoundaryValuehierarchy, | ||
| )); | ||
| setState(() { | ||
| visiable = false; |
| @@ -181,11 +181,11 @@ class _LoginPageState extends LocalizedState<LoginPage> { | |||
|
|
|||
| FormGroup buildForm() => fb.group(<String, Object>{ | |||
| _userId: FormControl<String>( | |||
| value: 'distributorUlongue', | |||
| value: 'wmgrDashboardAngonia', | |||
There was a problem hiding this comment.
Remove hardcoded credentials
Suggested change
| value: 'wmgrDashboardAngonia', |
| validators: [Validators.required], | ||
| ), | ||
| _password: FormControl<String>( | ||
| value: 'eGov@1234', | ||
| value: 'eGov@1234', |
There was a problem hiding this comment.
Remove hardcoded credentials
Suggested change
| value: 'eGov@1234', |
| @@ -37,7 +37,7 @@ extension ContextUtilityExtensions on BuildContext { | |||
| throw AppException('No project is selected'); | |||
| } | |||
|
|
|||
| return selectedBoundary; | |||
| return selectedBoundary.where((e) => e != '').toList().last; | |||
There was a problem hiding this comment.
Don't call last without checking if the list is empty. This will break
|
Will be merged as part of #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.