EGraph minimization with bisimulation #346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool |
|
However, I'm guessing that we won't want to merge and maintain this algorithm in egg itself. You may have more luck adding it to the extraction gym |
|
This is very cool! But I don't currently think it should be merged. It seems all of this could be implemented outside off egg in a separate crate, which is my preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented bisimulation to convert egraph to dtfa, minimize the dtfa, then convert the dtfa back to egraph. There is quite a bit of overhead but the code is all self contained. If someone wants to try optimizing the minimization code they can do that too.