Fix desugaring foreign primitives #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulshanabrook
commented
Aug 24, 2023
src/lib.rs
Outdated
Comment on lines
988
to
986
| let etype = self.proof_state.type_info.infer_literal(lit); | ||
| let etype = self.desugar.type_info.infer_literal(lit); |
There was a problem hiding this comment.
I thought about making a type_info method on the EGraph, to not have to go through desugar every time, but opted to leave it as is for a minimal change.
Happy to refactor to that though, if that is preferred.
There was a problem hiding this comment.
I like the type_info method idea!
There was a problem hiding this comment.
I gave that a go, refactoring all non-mutable usages of egraph.desugar.type_info.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug introduced by #176 which made foreign primitives desugar improperly. Closes #212.
It does this by moving the
TypeInfointo theDesugarstruct, as suggested by @oflatt.I removed the
ProofStatestruct, since it was just holding both theTypeInfoandDesugartogether.