-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort declaration cleanup #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally seems more sensible to me than the current implementation but I also am not that familiar with the original design decisions around how sorts are implemented. I would be curious to hear from whoever implemented it the way it is if this change seems appropriate, is that maybe @mwillsey? But looks good to me!
9a2a085
to
566ef8c
Compare
CodSpeed Performance ReportMerging #442 will improve performances by 27.3%Comparing Summary
Benchmarks breakdown
|
I had to cache the sort names to fix a performance regression with |
@yihozhang The ~20% speedup on |
Wow nice, that's a huge win! |
name
from basic sorts.get_sort
.Presort
trait.Rational
set lazy static.