Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt and BigRat #457

Merged
merged 4 commits into from
Oct 30, 2024
Merged

BigInt and BigRat #457

merged 4 commits into from
Oct 30, 2024

Conversation

Alex-Fischman
Copy link
Contributor

This PR adds BigInt and BigRat sorts by external demand. This PR does not add significant complexity to the codebase, as both BigInt and BigRat are implemented the same way as we've implemented Rational.

As a side effect, this PR also:

  • consolidates our dependency on num for BigInt
  • fixes a bug in the add_primitives macro to allow for arguments of different types
  • adds a very very small test

@Alex-Fischman Alex-Fischman requested a review from a team as a code owner October 29, 2024 22:56
@Alex-Fischman Alex-Fischman requested review from ezrosent, yihozhang and oflatt and removed request for a team and ezrosent October 29, 2024 22:56
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #457 will not alter performance

Comparing Alex-Fischman:big-int (b8a0548) with main (a38edb3)

Summary

✅ 8 untouched benchmarks

@yihozhang
Copy link
Collaborator

Thanks for the quick implementation! cc @rtzam

🐀

@Alex-Fischman Alex-Fischman requested review from yihozhang and removed request for oflatt October 30, 2024 06:31
@yihozhang yihozhang merged commit 225d0a1 into egraphs-good:main Oct 30, 2024
5 checks passed
@Alex-Fischman Alex-Fischman deleted the big-int branch October 30, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants