Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Doctrine Lexer v2.x + v3.x #341

Closed
phramz opened this issue Dec 27, 2022 · 3 comments
Closed

Support Doctrine Lexer v2.x + v3.x #341

phramz opened this issue Dec 27, 2022 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@phramz
Copy link

phramz commented Dec 27, 2022

Hey folks!
First of all thanks for this library, it does a great job so far 👍

I wonder if there are any plans to release a 4.x version any time soon, since it's getting harder to actually integrate it due to the hard dependency on Doctrine Lexer 1.x (current major 3.x). This will conflict with almost all new setups using a current version of Doctrine ORM/DBAL.

Cheers!
@phramz phramz mentioned this issue Dec 27, 2022
Closed
@egulias
Copy link
Owner

egulias commented Dec 28, 2022

Hey! Working on it, see #339 and #340

@egulias egulias added the dependencies Pull requests that update a dependency file label Dec 28, 2022
@phramz
Copy link
Author

phramz commented Dec 29, 2022 •
edited
Loading

Hey @egulias! I only looked at the issues and didn't find any regarding this ... just saw the existing PRs right after opening another #342 🙈 Sorry for the duplicates ... guess I'm still a bit dizzy from the holidays XD

@egulias
Copy link
Owner

egulias commented Jan 7, 2023

Resolved with 3.2.5 and 4.0.0

@egulias egulias closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doctrine Lexer v2.x + v3.x compat
2 participants
@egulias @phramz