-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to doctrine/lexer v3.0 #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for taking the time. Very nice PR to update the dependency, at last it brings a Token
type.
I have made a bunch of comments but please take a close look to Scrutinizer comments on the files. There are methods in the new version of the Lexer library that have types different to the one in the code.
Also check the Checks tab and see why tests are failing.
Looking forward to the changes. And thanks again for the PR!
4a1c758
to
69eaea4
Compare
Hey @egulias , Thank for your feedback, I applied them and fixed the tests. There was a type check issue due to the value I also finally managed to fix all Psalm issues so I'll let you review the changes 👍 |
doctrine/lexer v3.0.0 is also available now: |
Thank for the info @Pasqualle @egulias The main difference with this new v3.0.0 version is the dropped support for PHP <8.1. From what I have read in your readme, we should create a new v4.x release branch. |
Note that Lexer 3 is Lexer 2 minus the deprecation layer, so requiring Lexer 3 without allowing v2 as well is not really necessary. Lexer 3 is not supported by Doctrine ORM 2 and it likely won't ever be. This basically means that bumping to |
I've submitted #340 to unblock Lexer 2 (and doctrine/annotations 2) in Symfony's CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are almost there! A couple of more changes please.
I'll create the 4.x branch and will request you to do the PR to that branch, once we have sorted out all the changes on this PR (so keep the conversation in one place).
Thanks!
Great thank you for your feedback. Here are the requested changes. 👍 |
composer.json
Outdated
"doctrine/lexer": "^1.2", | ||
"symfony/polyfill-intl-idn": "^1.15" | ||
"php": ">=8.1", | ||
"doctrine/lexer": "^3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I would strongly recommend to loosen this constraint to…
"doctrine/lexer": "^3.0", | |
"doctrine/lexer": "^2.0 || ^3.0", |
This should be possible without much extra effort and avoid dependency conflicts downstream for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
@Ph0tonic please close this PR and create a new one against v4 branch: https://github.com/egulias/EmailValidator/tree/4.x . |
Closing in favor of #344 |
You mean #344, I guess. 🙃 |
Updated, thanks! |
Doctrine/L just released a brand new version 3.0 and here is a PR to use this newer version.
Let me know @egulias if I need to change anything, I am not familiar with psalm annotations.