Auto multi validation #335
Conversation
|
Thanks to this, I can now easily handle all the information and save it in the database. |
| * @param string $emailAddress | ||
| * @return array | ||
| */ | ||
| public static function create(string $emailAddress): array |
There was a problem hiding this comment.
Which are the reasons behing making it static? It prevents being injected as dependency.
There was a problem hiding this comment.
Also, you are returning the lists of results, not a validator ready for use. I'd suggest to change the name to something like validationsResults or similar.
| $validator = new EmailValidator(); | ||
| $result = []; | ||
|
|
||
| foreach (self::$defaultValidators as $key => $val) { |
There was a problem hiding this comment.
You could just use ´MultipleValidationWithAnd´ at construction time. And remove line 15.
| class EmailValidatorFactory | ||
| { | ||
| /** @var [] */ | ||
| protected static array $defaultValidators = [ |
There was a problem hiding this comment.
Are you expecting or encouraging extension? This prevents it. There is also no entry point to add additional/other validators than this.
You can do it via constructor arguments with sensible defaults (is like your idea here, but with simple extension point)
| $result[get_class(new $val)] = $validator->isValid($emailAddress, new $val); | ||
| } | ||
|
|
||
| return $result; |
There was a problem hiding this comment.
Is the validator's Result type not useful? Maybe adding which validation is giving which result would be useful?
I created this branch to have every validation in one place by class name.
Example use: