Allow searching on Postgres #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. One way how to know if it's postgres or not, is to look at the %Oban.Config{
engine: ...
}There are 3 engines:
|
egze
reviewed
Nov 24, 2024
lib/obanalyze/oban_jobs.ex
Outdated
| @@ -59,7 +59,7 @@ defmodule Obanalyze.ObanJobs do | |||
|
|
|||
| from oj in query, | |||
| where: like(oj.worker, ^like), | |||
| or_where: like(oj.args, ^like) | |||
| or_where: like(fragment("?::text", oj.args), ^like) | |||
There was a problem hiding this comment.
I think this is a postgres way of casting and sqlite doesn't do it like this. Try the explicit cast() function that both DBs support.
maltoe
force-pushed
the
allow-searching-on-postgres
branch
from
a47ec9b to
5d25c93
Compare
This patch changes the search implementation to explicitly cast the jsonb args column to `text` before passing it to `like/2`.
maltoe
force-pushed
the
allow-searching-on-postgres
branch
from
5d25c93 to
f4218c5
Compare
egze
reviewed
Nov 25, 2024
Co-authored-by: Aleksandr Lossenko <aleksandr.lossenko@gmail.com>
|
Great work, really appreciate it! Your PR now makes me think that I need to setup different integration tests for Postgres and SQLite. Otherwise it can be tricky to know which queries work or not. Problem for future me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @egze
This patch changes the search implementation to explicitly cast the jsonb args column to
textbefore passing it tolike/2, as PostgreSQL (at least version <=15) does not supportjsonb ~~ textlike sqlite does.I'd also like to also switch the
liketoilikefor Postgres as it defaults to case-sensitive search, but not sure how to get the adapter fromOban.Repo.Great work, your library hits a sweet spot for me with its functionality & scope 👍