Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #87, ClassLoader fun. For real this time, tests and all #109

Closed
wants to merge 2 commits into from

Conversation

timeck
Copy link
Contributor

@timeck timeck commented Oct 13, 2014

Some notes about what this is about:

  • Implemented Cache.getRuntimeConfiguration by copying config used to create cache. Mutators still throw exceptions
  • Allow discrete classloaders for a CacheManager and for individual Caches
  • If a classloader is specified for a CacheManager, caches created in that manager will inherit the classloader if the CacheConfiguration does not specify another explicitly
  • The default classloading behavior same as ehcache 2.x, prefer TCCL then use loader that loaded ehcache
  • changed java.util.ServiceLoader calls to explicitly use the classloader that loads ehcache
  • Plumbed ClassLoader down to Store.Confuguration. My believe is that Store's will need to be told the classloader
  • There are multiple parseConfiguration() signatures now in org.ehcache.config.xml.XmlConfiguration that let people specify the classloaders when interacting with xml configs
  • It's not yet clear to me where user specified classes (for maybe something like a CacheWriterFactory) will be instantiated, but those calls would need to get a classloader provided to them

@terracotta-org
Copy link
Contributor

Test PASSed.

@ljacomet
Copy link
Member

Looks ok to me

@alexsnaps
Copy link
Member

Think it needs rebasing, but could then be merged in. (Ehcaching disappeared for instance... should create some 'trouble')

@alexsnaps alexsnaps closed this in 9eb613a Oct 17, 2014
@timeck timeck deleted the issue-87 branch October 18, 2014 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants