Fix #2337 : Ensure we break out of reconnect loop when the entity does not exist #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henri-tremblay
suggested changes
Mar 16, 2018
| @@ -181,6 +191,14 @@ public void testDestroyCacheWithCacheManagerStopped() throws CachePersistenceExc | |||
| assertThat(persistentCacheManager.getStatus(), is(Status.UNINITIALIZED)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testDestroyNonExistentCacheWIthCacheManagerStopped() throws CachePersistenceException { | |||
There was a problem hiding this comment.
'I' should be lowercase
| reconnect(); | ||
| retrieveEntity(); | ||
| connectionRecoveryListener.run(); | ||
| return; |
There was a problem hiding this comment.
could be a break. To look like the rest of the code
| connectionRecoveryListener.run(); | ||
| return; | ||
| } catch (ConnectionClosedException | ConnectionShutdownException e) { | ||
| LOGGER.info("Disconnected to the server", e); |
chrisdennis
force-pushed
the
issue-2337
branch
2 times, most recently
from
d2f4179
to
b633de6
Compare
…ity does not exist
cljohnso
approved these changes
Mar 16, 2018
henri-tremblay
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.