Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue starting with 0.1.17 #168

Closed
dburkland opened this issue Aug 23, 2021 · 5 comments · Fixed by #169
Closed

Issue starting with 0.1.17 #168

dburkland opened this issue Aug 23, 2021 · 5 comments · Fixed by #169
Milestone

Comments

@dburkland
Copy link
Contributor

Using the same set of video files in a given directory I have no issues w/ 0.1.16 however with every version since 0.1.17 I get the following errors:

root@tesla-dashcam-encoder:~# time tesla_dashcam --layout DIAMOND --scale 1 --quality HIGH --compression ultrafast --encoding x265 --set_moviefile_timestamp RENDER --output ${DATE}_diamond_1_high_ultrafast_x265.mp4 /root/TeslaCam/
Scanning 1 folder(s)
There are 1 event folder(s) with 7 clips to process.
Processing 7 clips in folder /root/TeslaCam/ (1/1)
Processing clip 1/7 from 12/19/19 11:44:07 and 59 seconds long.
Traceback (most recent call last):
File "/usr/local/bin/tesla_dashcam", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/tesla_dashcam/tesla_dashcam.py", line 4500, in main
process_folders(
File "/usr/local/lib/python3.8/dist-packages/tesla_dashcam/tesla_dashcam.py", line 2770, in process_folders
if create_intermediate_movie(
File "/usr/local/lib/python3.8/dist-packages/tesla_dashcam/tesla_dashcam.py", line 2059, in create_intermediate_movie
if event_info.metadata["reason"] == "SENTRY"
TypeError: 'NoneType' object is not subscriptable

Any ideas?

@ehendrix23 ehendrix23 modified the milestones: v0.1.19, v0.1.17 Aug 23, 2021
@ehendrix23
Copy link
Owner

Thank you for reporting. Found the issue and currently doing test on fix. Fix will be in v0.1.19 most likely released today.

@dburkland
Copy link
Contributor Author

You da man @ehendrix23, appreciate the quick response!

Dan

@ehendrix23
Copy link
Owner

Problem is when there is no events.json file within the folder. Deleted a events.json file in one of my test folders allowing me to reproduce and test the fix.
While testing the fix it failed on another item, similar cause. So just went through the code to fix anywhere it could happen. Test on the 1 folder with 1 scenario without events.json file was now successful. Running tests now going through multiple scenarios and multiple folders to confirm no further issues.

@dburkland
Copy link
Contributor Author

Awesome thanks for the update @ehendrix23.

Dan

ehendrix23 added a commit that referenced this issue Aug 28, 2021
 when there is no events.json file (#168)
@ehendrix23
Copy link
Owner

Fix is in 0.1.19. Closing issue, re-open or create a new issue if same problem still occurs.

@ehendrix23 ehendrix23 linked a pull request Aug 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants