Use log-process-errors

nodemon.debug.json

@@ -1,4 +1,4 @@
 {
-  "exec": "cd ./examples && NODE_ENV=dev node --inspect-brk --no-warnings --stack-trace-limit=20 index.js",
+  "exec": "cd ./examples && NODE_ENV=dev node --inspect-brk --stack-trace-limit=20 index.js",
   "ext": ".js,.json,.yml,.yaml"
 }

nodemon.json

@@ -1,4 +1,4 @@
 {
-  "exec": "cd ./examples && NODE_ENV=dev node --inspect --no-warnings --stack-trace-limit=20 index.js",
+  "exec": "cd ./examples && NODE_ENV=dev node --inspect --stack-trace-limit=20 index.js",
   "ext": ".js,.json,.yml,.yaml"
 }

package.json

@@ -77,6 +77,7 @@
     "js-yaml": "^3.12.1",
     "json5": "^2.1.0",
     "li": "^1.3.0",
+    "log-process-errors": "^2.0.0",
     "moize": "^5.4.1",
     "mongodb": "^2.2.36",
     "mustache": "^2.3.2",

src/run/exit/graceful_exit.js

@@ -13,12 +13,14 @@ const { emitStopEvent } = require('./stop_event')
 const mmGracefulExit = async function({
   protocolAdapters,
   dbAdapters,
+  stopProcessErrors,
   config,
 }) {
   const measures = []
   const { exit } = await mGracefulExit({
     protocolAdapters,
     dbAdapters,
+    stopProcessErrors,
     config,
     measures,
   })
@@ -46,9 +48,12 @@ const eGracefulExit = addErrorHandler(oGracefulExit, gracefulExitHandler)
 const gracefulExit = async function({
   protocolAdapters,
   dbAdapters,
+  stopProcessErrors,
   config,
   measures,
 }) {
+  stopProcessErrors()
+
   const protocolPromises = closeProtocols({
     protocolAdapters,
     config,

src/run/exit/setup.js

@@ -11,10 +11,16 @@ const { gracefulExit } = require('./graceful_exit')
 // Make sure the server stops when graceful exits are possible
 // Also send related events
 // We cannot handle `process.exit()` since graceful exit is async
-const setupGracefulExit = function({ protocolAdapters, dbAdapters, config }) {
+const setupGracefulExit = function({
+  protocolAdapters,
+  dbAdapters,
+  stopProcessErrors,
+  config,
+}) {
   const exitFunc = gracefulExit.bind(null, {
     protocolAdapters,
     dbAdapters,
+    stopProcessErrors,
     config,
   })
 

src/run/process.js

@@ -1,7 +1,6 @@
 'use strict'
 
-const process = require('process')
-const { inspect } = require('util')
+const logProcessErrors = require('log-process-errors')
 
 const { logEvent } = require('../log')
 const { createPb } = require('../errors')
@@ -12,60 +11,30 @@ const { createPb } = require('../errors')
 // Note that process events fired that do not belong to autoserver might be
 // caught as well.
 const processErrorHandler = function({ config }) {
-  process.on('unhandledRejection', unhandledHandler.bind(null, config))
-  process.on('multipleResolves', multipleResolvesHandler.bind(null, config))
-  process.on('rejectionHandled', rejectionHandledHandler.bind(null, config))
-  process.on('warning', warningHandler.bind(null, config))
-}
-
-const unhandledHandler = async function(config, value) {
-  const { suffix, innererror } = getPromiseValue(value)
-  const message = `A promise was rejected${suffix} and not handled right away`
-
-  await emitProcessEvent({ message, innererror, config })
-}
-
-// eslint-disable-next-line max-params
-const multipleResolvesHandler = async function(config, type, promise, value) {
-  const { suffix, innererror } = getPromiseValue(value)
-  const message = `A promise was ${type}d${suffix} after being already settled`
-
-  await emitProcessEvent({ message, innererror, config })
-}
-
-const getPromiseValue = function(value) {
-  if (value instanceof Error) {
-    return { suffix: '', innererror: value }
-  }
-
-  return { suffix: ` with value '${value}'` }
-}
-
-const rejectionHandledHandler = async function(config, promise) {
-  const message = `A promise was rejected but handled too late: ${inspect(
-    promise,
-  )}`
-
-  await emitProcessEvent({ message, config })
+  const stopProcessErrors = logProcessErrors({
+    ...LOG_PROCESS_ERRORS_OPTS,
+    log: emitProcessEvent.bind(null, { config }),
+  })
+  return { stopProcessErrors }
 }
 
-const warningHandler = async function(config, error) {
-  const { message, code, detail } = error
-  const nextLine = [code, detail]
-    .filter(string => string !== undefined)
-    .join(':')
-  const messageA = `${message}\n${nextLine}`
-
-  await emitProcessEvent({ message: messageA, innererror: error, config })
+const LOG_PROCESS_ERRORS_OPTS = {
+  colors: false,
+  exitOn: [],
+  // See https://github.com/nodejs/node/issues/24321
+  // We could log it as a `message` instead but it would lack the stack trace,
+  // making it less useful.
+  level: { multipleResolves: 'silent' },
 }
 
 // Report process problems as events with event 'failure'
-const emitProcessEvent = async function({ message, innererror, config }) {
-  const error = createPb(message, { reason: 'ENGINE', innererror })
+const emitProcessEvent = function({ config }, message, level) {
+  const error = createPb(message, { reason: 'ENGINE' })
 
-  await logEvent({
+  return logEvent({
     event: 'failure',
     phase: 'process',
+    level,
     params: { error },
     config,
   })