README: Document our license-list version, parens issue, and license #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
document-license-list-version
branch
from
87bc37a to
3514161
Compare
Generated with: $ curl -s https://www.apache.org/licenses/LICENSE-2.0.txt >LICENSE-APACHE
Generated with: $ curl -s https://raw.githubusercontent.com/rust-lang/rust/1.23.0/LICENSE-MIT >LICENSE-MIT Rust dropped their copyright line from LICENSE-MIT in rust-lang/rust@2a8807e8 (LICENSE-MIT: Remove inaccurate (misattributed) copyright notice, 2017-07-26, [1]). I'm not clear on how that interacts with the "The above copyright notice and this permission notice shall be included..." line [2], but it's better than not including the MIT text at all (which is where we were before this commit). Josh Triplett responded to my concerns with: On Thu, Jan 11, 2018 at 08:04:39PM +0000, Josh Triplett wrote [3]: > I don't believe so, no. The requirement is to reproduce what's > there; if something isn't there you don't need to reproduce it. which is good enough for me. [4] has the same text (although it has a copyright template), but using Rust as the source gets us the Rust-standard line wrappings ;). [1]: rust-lang/rust@2a8807e [2]: rust-lang/rust#43498 (comment) [3]: rust-lang/rust#43498 (comment) [4]: https://opensource.org/licenses/MIT
The "at your option" language is modeled on Rust's from rust-lang/rust@00c856c0 (Update license, add license boilerplate to most files, 2012-12-03), although I've made it more compact by using Markdown for the upstream license links. I'd rather leave caller bugs to the issue tracker, but the paren bug is an important issue for folks writing license expressions (i.e. all crate authors), so I'm calling it out on our README until we get it fixed. There's an open SPDX issue about providing browsable archives for past License List releases [1]. Until that's resolved, I'm just linking to a tag in the release repository. [1]: spdx/LicenseListPublisher#11
wking
force-pushed
the
document-license-list-version
branch
from
3514161 to
fe8a21e
Compare
|
I've bumped this to the 3.0 license list now that #11 has landed. I'll give this a week to cook and then land it unless someone raises concerns with it ;). |
wking
added a commit
to wking/license-exprs
that referenced
this pull request
Jun 18, 2018
Changes since v1.3.0: * Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24) * Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8). * Document our license-list version, parens issue, and license (ehuss#16, ehuss#17). * Add Travis CI configuration (ehuss#22). * Add additional test cases (ehuss#25). * .mailmap: Consolidate authors (ehuss#26).
wking
added a commit
to wking/license-exprs
that referenced
this pull request
Jun 18, 2018
Changes since v1.3.0: * Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24). * Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8). * Document our license-list version, parens issue, and license (ehuss#16, ehuss#17). * Add Travis CI configuration (ehuss#22). * Add additional test cases (ehuss#25). * .mailmap: Consolidate authors (ehuss#26).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “at your option” language is modeled on Rust's from rust-lang/rust@00c856c0 (2012-12-03), although I've made it more compact by using Markdown for the upstream license links.
I'd rather leave caller bugs to the issue tracker, but the paren bug is an important issue for folks writing license expressions (i.e. all crate authors), so I'm calling it out on our README until we get it fixed.
I've also added local files with license text for this package. These files match what's in Rust 1.23.0, modulo some whitespace in
LICENSE-APACHE(which I've pulled directly from apache.org).Fixes #15.