Related Selects + Chosen #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some frameworks - like 'chosen' - creates visual elements to represent real selects. When an option is marked as 'selected' programmatically, it don't fire 'change' event. This fix trigger 'change' event whenever is necessaray, so it can be listened by others. It was necessary also to create a 'onAfterReset' to allow others to intercept the first moment a select turns 'disabled' as triggering 'change' without changing the selected option doesn't cause event 'change' to be triggered properly (because nothing changes of course).
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to allow use of related selects with frameworks like 'chosen'.
With this improvements is possible to hook in callbacks and update visual representations of related selects.