Skip to content

Commit

Permalink
Remove redundant edm4eic RawCalorimeterHit type (#87)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
Remove redundant edm4eic RawCalorimeterHit type. EICrecon uses edm4hep
RawCalorimeterHit type everywhere which has signed members instead of
unsigned ones here.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?
  • Loading branch information
rahmans1 authored Jul 26, 2024
1 parent 933649d commit fe43bd6
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions edm4eic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -234,17 +234,6 @@ datatypes:
## ==========================================================================
## Calorimetry
## ==========================================================================
edm4eic::RawCalorimeterHit:
Description: "Raw (digitized) calorimeter hit"
Author: "W. Armstrong, S. Joosten"
Members:
- uint64_t cellID // The detector specific (geometrical) cell id.
- uint64_t amplitude // The magnitude of the hit in ADC counts.
## @TODO: should we also add integral and time-over-threshold (ToT) here? Or should
## those all be different raw sensor types? Amplitude is
## really not what most calorimetry sensors will give us AFAIK...
- uint64_t timeStamp // Timing in TDC

edm4eic::CalorimeterHit:
Description: "Calorimeter hit"
Author: "W. Armstrong, S. Joosten"
Expand Down

0 comments on commit fe43bd6

Please sign in to comment.