Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add association datatype MCRecoTrackerHitAssociation #23

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Feb 24, 2023

Briefly, what does this PR introduce?

Add new one-to-many association datatype to link digitized tracker hits (RawTrackerHit) to the MC-level SimTrackerHits. Close #21.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@c-dilks c-dilks requested a review from a team as a code owner February 24, 2023 22:19
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I wonder if you can submit this to EDM4hep as well as a PR, along with a version for SimCalorimeterHit vis à vis RawCalorimeterHit?

@sly2j sly2j self-assigned this Feb 27, 2023
@c-dilks
Copy link
Member Author

c-dilks commented Mar 2, 2023

Shall we merge this here now, and upstream things to EDM4hep later?

@wdconinc wdconinc merged commit 1556c6d into main Mar 2, 2023
@wdconinc wdconinc deleted the add_MCRecoTrackerHitAssociation branch March 2, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add association or relation for RawPMTHit to MC
3 participants