feat: add version header #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Aug 11, 2023
16 tasks
wdconinc
commented
Aug 14, 2023
veprbl
previously approved these changes
Aug 14, 2023
veprbl
reviewed
Aug 14, 2023
wdconinc
force-pushed
the
version-header
branch
from
db02e9f
to
b53357c
Compare
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
`2.1.0` is not a valid literal
wdconinc
force-pushed
the
version-header
branch
from
1691fb3
to
39d8733
Compare
sly2j
approved these changes
Aug 15, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Aug 16, 2023
### Briefly, what does this PR introduce? This will force rebuilding of the datamodel glue headers in local development copies when the data model changes version. Depends on: - [x] upgrade eic-shell to EDM4hep 0.9, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/689 - [x] roll out eic-shell with EDM4hep 0.9 to cvmfs and github actions - [ ] ~~update minimum required EDM4hep version to 0.9~~ (compatibility is ensured by febc5f7) - [x] update EDM4eic to provide version header, eic/EDM4eic#40, - [x] release new EDM4eic version 2.1.0 - [x] upgrade eic-spack to provide EDM4eic version 2.1.0, eic/eic-spack#521 - [x] upgrade eic-shell to EDM4eic 2.1, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/690 - [x] roll out eic-shell with EDM4eic 2.1 to cvmfs and github actions - [ ] ~~update minimum required EDM4hep version to 2.1~~ (compatibility is ensured by febc5f7 ) ### What kind of change does this PR introduce? - [x] Bug fix (issue: `cmake --fresh` does not rebuild datamodel glue header when switching datamodel versions) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds a version header to the installation of EDM4eic. This allows us to make downstream code behave differently based on the version.
Note: with
.gitattributes(in particularexport-subst) we could automate the filling of this version information with the most recent tag and such. Maybe something to look into.