feat: Measurement2D to represent 2D surface measurements #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable easy tracker hit to trajectory relation. As proposed by Wouter at https://indico.bnl.gov/event/20713/
ShujieL
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds a new datatype,
Measurement2D, intended primarily but not exclusively for use in Acts track finding. Therefore it tends to mirror what we are already doing. The datatype stores two-dimensional (+time) constraints on a surface with identifier.edm4hep::Vector2f locTimeErroris added as a separate field since it is likely to be set to zero often. This makes interactions with the datatype more straightforward than imposing a full 3DlocTimeand 3D triangular covariance matrix.There is additional motivation and discussion at https://docs.google.com/presentation/d/1ee_iRAyeUao7PwkmFnapX7cASAp4rm8QnQ_moidYDnk/edit, but changes may be applied here without updating the slides.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No. Addition of new datatype.
Does this PR change default behavior?
No.